range: draw slider on top of all contents

This is so that e.g. the focus ring is drawn under the slider.

diff --git a/gtk/gtkrange.c b/gtk/gtkrange.c
index e8f04d50bba609e2678dbfcb5a3d94516899c6f1..b665ec299bfd62849aff5a7c21c82cc4ed3cf917 100644 (file)
--- a/gtk/gtkrange.c
+++ b/gtk/gtkrange.c
@@ -2297,8 +2297,6 @@ gtk_range_render_trough (GtkCssGadget *gadget,
   if (priv->has_origin)
     gtk_css_gadget_draw (priv->highlight_gadget, cr);
 
-  gtk_css_gadget_draw (priv->slider_gadget, cr);
-
   return gtk_widget_has_visible_focus (widget);
 }
 
@@ -2318,13 +2316,11 @@ gtk_range_render (GtkCssGadget *gadget,
   /* HACK: we can't render the contents box directly because
    * GtkColorScale wants to omit the trough but still draw the slider...
    */
-  if (GTK_IS_COLOR_SCALE (widget))
-    {
-      gtk_css_gadget_draw (priv->slider_gadget, cr);
-      return FALSE;
-    }
+  if (!GTK_IS_COLOR_SCALE (widget))
+    gtk_css_gadget_draw (priv->contents_gadget, cr);
 
-  gtk_css_gadget_draw (priv->contents_gadget, cr);
+  /* Draw the slider last, so that e.g. the focus ring stays below it */
+  gtk_css_gadget_draw (priv->slider_gadget, cr);
 
   return FALSE;
 }